Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document): accepts nodearray for head's children #35424

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 18, 2022

This PR attempts to amends #35390.

There's new property 'children' in OriginProps : https://github.com/vercel/next.js/blob/canary/packages/next/pages/_document.tsx#L22 which overwrites default prop's children defined at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L504. Those 2 are incompatible, especially new one doesn't allow iterable children which results multiple children in head tag makes compilation fails.

PR matches type of new property same as default, then apply some workaround to bend over internal check logics. I'm not sure if it's worth to apply strict types as much or just bend it via any casting, PR tried to be strict as much.

Bug

test is added in #35426

@ijjk
Copy link
Member

ijjk commented Mar 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
buildDuration 13.6s 14.5s ⚠️ +962ms
buildDurationCached 5.8s 5.3s -515ms
nodeModulesSize 456 MB 456 MB ⚠️ +249 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
/ failed reqs 0 0
/ total time (seconds) 2.898 2.986 ⚠️ +0.09
/ avg req/sec 862.54 837.15 ⚠️ -25.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.275 1.32 ⚠️ +0.05
/error-in-render avg req/sec 1960.92 1894.02 ⚠️ -66.9
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
buildDuration 17.9s 16.4s -1.5s
buildDurationCached 5.2s 5.3s ⚠️ +67ms
nodeModulesSize 456 MB 456 MB ⚠️ +249 B
Page Load Tests Overall increase ✓
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
/ failed reqs 0 0
/ total time (seconds) 2.822 2.732 -0.09
/ avg req/sec 885.94 914.92 +28.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.211 1.22 ⚠️ +0.01
/error-in-render avg req/sec 2064.9 2048.83 ⚠️ -16.07
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js fix-type-children-head Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 2e748f9

@kodiakhq kodiakhq bot merged commit 9c2949a into vercel:canary Mar 18, 2022
kodiakhq bot pushed a commit that referenced this pull request Mar 18, 2022
@kwonoj kwonoj deleted the fix-type-children-head branch March 18, 2022 14:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom document's head throws error with multiple children
3 participants